Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On .NET 8 when using the configuration code generators, remove the RequiresUnreferencedCode atrributes #2574

Closed
jmprieur opened this issue Nov 7, 2023 · 0 comments · Fixed by #2575
Closed

On .NET 8 when using the configuration code generators, remove the RequiresUnreferencedCode atrributes #2574

jmprieur opened this issue Nov 7, 2023 · 0 comments · Fixed by #2575
Labels
needs attention untriaged

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Nov 7, 2023

Microsoft.Identity.Web Library

Microsoft.Identity.Web

Microsoft.Identity.Web version

2.15.3

Web app

Not Applicable

Web API

Not Applicable

Token cache serialization

Not Applicable

Description

We have attributes to help trimmability on .NET 6 and 7
but on .NET we also have the code generators for the bind and configure, so when they apply we don't need to exclude the corresponding methods from trimmability.

Reproduction steps

See jmprieur/betterTrimNet8 branch

Error message

No response

Id Web logs

No response

Relevant code snippets

See jmprieur/betterTrimNet8 branch

Regression

No response

Expected behavior

Only have the attributes when not using the code generators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs attention untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to have better trimmability on .NET 8 AzureAD/microsoft-identity-web
1 participant
@jmprieur