[Feature Request] Make internal constants class public

[UM001]

In the AccountController example constants are used. However, those constants are internal and not public usable.
Maybe make them usable? Same for AzureAdB2C, I used it from other library instead this one.

https://github.com/AzureAD/microsoft-identity-web/blob/master/src/Microsoft.Identity.Web.UI/Areas/MicrosoftIdentity/Controllers/AccountController.cs

namespace Microsoft.Identity.Web
{
//
// Summary:
// General constants.
[NullableAttribute(0)]
[NullableContextAttribute(1)]
internal static class Constants
{
public const string TenantDiscoveryEndpoint = "tenant_discovery_endpoint";
public const string AzureAdB2C = "AzureAdB2C";
public const string PreferredUserName = "preferred_username";
public const string NameClaim = "name";
public const string Tfp = "tfp";
public const string Consent = "consent";
public const string ConsentUrl = "consentUri";
`

[jennyf19]

makes sense. @jmprieur thoughts? only issue i see is breaking changes if we change the constant values, we have flexibility to do that right now.

[jmprieur]

yes, I agree. This is the problem (avoiding breaking changes)
@UM001 : is there constants in particular you'd want to see?

[UM001]

For the account controller I used next.
I believe the AzureAd and AzureAdB2c are also commonly used, and api. If that can avoid adding other references that would be great.

public static class Constants { public const string Policy = "policy"; public const string LoginHint = "loginhint"; public const string DomainHint = "domainhint"; public const string Claims = "claims"; public const string Scope = "scope"; }

[pmaytak]

The idea behind the Constants class was so that we internally don't have to type out all the literal strings, which can be added/changed/removed as the library develops. This class has a lot of unrelated constants, which will not be useful to the end users and, if made public, can add more confusion to the API.

There's public ClaimConstants class that has some of the constants that you mentioned. This class is more stable since it represents constants for claim types that won't change.

I am hesitant to make Constants.cs public. But maybe we can extract and move some of the constants (that are useful to the users) to a different public class like ClaimConstants.

[jmprieur]

@UM001 : which constants would you want to see public?

[jennyf19]

@jmprieur - @UM001 listed them above.
I went ahead and did a quick experiment w/moving some of our constants to a public. Opened a pr to gather feedback. Thought better to start w/a smaller list, as we can add to it, but not take away.

@UM001 would especially appreciate your input. I didn't include "Policy" as we use UserFlow for B2C, and AzureAD also has the concept of Policy, so I thought it might be more confusing. I've included the rest on your list.

[UM001]

I think you have added them already. Great.

public static class Constants { public const string Policy = "policy"; public const string LoginHint = "loginhint"; public const string DomainHint = "domainhint"; public const string Claims = "claims"; public const string Scope = "scope"; public const string UILocales = "uilocales"; public const string AzureAd = "AzureAd"; public const string AzureAdB2c = "AzureAdB2c"; }

and those are of Woodgrove sample:

public static class ClaimTypes { public const string IdentityProvider = "http://schemas.microsoft.com/identity/claims/identityprovider"; public const string Issuer = "iss"; public const string Name = "name"; public const string ObjectIdentifier = "http://schemas.microsoft.com/identity/claims/objectidentifier"; public const string OrganizationName = "organization_name"; public const string OwnerIdentifier = "owner_id"; public const string TenantIdentifier = "http://schemas.microsoft.com/identity/claims/tenantid"; public const string TrustFrameworkPolicy = "tfp"; }

This class also holds constants.
System.Security.Claims { // // Summary: // Defines constants for the well-known claim types that can be assigned to a subject. // This class cannot be inherited. public static class ClaimTypes

[jmprieur]

@UM001, this is available in Microsoft.Identity.Web 1.0.0