Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Constants.LoginHint should value login_hint, not loginHint (and domain_hint for DomainHint) #798

Closed
jmprieur opened this issue Dec 2, 2020 · 2 comments
Closed

[Bug] Constants.LoginHint should value login_hint, not loginHint (and domain_hint for DomainHint) #798

jmprieur opened this issue Dec 2, 2020 · 2 comments
Assignees
@jennyf19
Labels
bug Something isn't working fixed P1
Milestone
1.4.0

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Dec 2, 2020

Which version of Microsoft Identity Web are you using?
1.3.0

Where is the issue?

  • Web app
    • [ x ] Sign-in users
    • [ x ] Sign-in users and call web APIs

Repro

Call AccountController.Challenge with a loginHint.

var your = (code) => here;

Expected behavior
The call to AAD should show login_hint

Actual behavior
It's not

Possible solution
Change the value of the LoginHint to login_hint

microsoft-identity-web/src/Microsoft.Identity.Web/Constants/Constants.cs

Line 15 in a4bde02

public const string LoginHint = "loginHint";

Same for DomainHint which should value domain_hint

Additional context / logs / screenshots
Add any other context about the problem here, such as logs and screenshots.
@jmprieur jmprieur added bug Something isn't working P1 labels Dec 2, 2020
@jmprieur jmprieur added this to the 1.4.0 milestone Dec 2, 2020
@jmprieur
Copy link
Collaborator Author

jmprieur commented Dec 2, 2020 •
edited
Loading

@jennyf19 do you agree?
See also https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/6e7a53e241e4566998d3bf365f03acd0da699a31/src/Microsoft.IdentityModel.Protocols.OpenIdConnect/OpenIdConnectParameterNames.cs#L55

@jennyf19 jennyf19 mentioned this issue Dec 2, 2020
Merged
@jennyf19 jennyf19 added the fixed label Dec 2, 2020
@jennyf19 jennyf19 self-assigned this Dec 3, 2020
@jmprieur jmprieur mentioned this issue Dec 5, 2020
Merged
@jennyf19
Copy link
Collaborator

jennyf19 commented Dec 9, 2020

Included in 1.4 Release.

@jennyf19 jennyf19 closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennyf19 jennyf19

Labels
bug Something isn't working fixed P1
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
2 participants
@jmprieur @jennyf19