Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda build errors #474

Closed
CagtayFabry opened this issue Aug 14, 2021 · 5 comments
Closed

conda build errors #474

CagtayFabry opened this issue Aug 14, 2021 · 5 comments
Labels
bug Something isn't working CI close Mark an issue when you think it can be closed but want confimation before closing it file weldx file handling (WeldxFile)

Comments

@CagtayFabry
Copy link
Member

CagtayFabry commented Aug 14, 2021

In current PRs there are a few errors (and lots of warnings) popping up in the conda build CI pytest run (example)

The errors do not appear on the pypi build run

errors

warnings

  • every test marked with slow throws a warning because the pytest marker is not recognized.
    I guess this has to do with the setup.cfg not being part of the distribution, hence the pytest config is not applied.

others

maybe unrelated but these two errors popping up with WeldxFile.test_custom_schema also don't make a lot of sense to me
since we currently use asdf.info (which at least seems to do some kind of type resolving under the hood) to create the console output that is a little hard to debug, can we revert that to simply print the yaml string in the console again @marscher ?

@CagtayFabry CagtayFabry added bug Something isn't working CI file weldx file handling (WeldxFile) labels Aug 14, 2021
@CagtayFabry CagtayFabry mentioned this issue Aug 14, 2021
12 tasks
@CagtayFabry
Copy link
Member Author

This might be related to updated dependencies in the k3d conda build, testing now (woulöd fit the timeframe of the error appearing)

@CagtayFabry
Copy link
Member Author

#473 seems to have solved the errors for now

@CagtayFabry CagtayFabry added the close Mark an issue when you think it can be closed but want confimation before closing it label Sep 14, 2021
@CagtayFabry
Copy link
Member Author

I think this has been solved?
the only thing still open are the pytest marker warnings but I'm not sure we can do mcuh about those (also they don't really matter for the build runs)

@marscher
Copy link
Contributor

I think these warnings arise from the conftest.py not being shipped to the testing (run) folder.

@CagtayFabry
Copy link
Member Author

yes true for the warning, but I believe this is fine for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI close Mark an issue when you think it can be closed but want confimation before closing it file weldx file handling (WeldxFile)
Projects
None yet
Development

No branches or pull requests

2 participants