-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention regarding $\nabla u$ #56
Comments
@saifr68 we should probably deal with this before you merge your stress-rate branch |
I say let's just stick to what is already implemented and mention this in the documentation. And whenever an implementation method of some author is used we just check if the convention matches. If not, we make the necessary adjustments accordingly |
I mean, my preferred way of implementing stuff is in Rust and there the memory-layout is column-wise instead of row-wise as it is in FEniCS. So I need to watch out for transposition anyways. So I am fine with either with a slight preference towards Any more opinions on this @aradermacher , @pdiercks, @joergfunger ? |
I'm fine with Saifs suggestion |
I think the suggestion of @srosenbu is more intuitive, but just make sure it is correctly documented. |
Currently, we use$\nabla u$ which means $\partial u_j/\partial x_i$ . Some other sources however define it as $\nabla u = \partial u_i/\partial_j$ which is represented in ufl as
ufl.nabla_grad
forufl.grad
.Which one do we want to use? Since this can be a really annoying source of error, we should make sure we use it consistently
The text was updated successfully, but these errors were encountered: