Skip to content
This repository has been archived by the owner on Sep 13, 2024. It is now read-only.

EthereumKeystoreV3 constructor with KeystoreParamsV3 #17

Closed
6epreu opened this issue Feb 26, 2018 · 4 comments
Closed

EthereumKeystoreV3 constructor with KeystoreParamsV3 #17

6epreu opened this issue Feb 26, 2018 · 4 comments

Comments

@6epreu
Copy link

6epreu commented Feb 26, 2018

It will be useful to have such constructor in EthereumKeystoreV3

@shamatar
Copy link
Contributor

public convenience init?(_ jsonString: String)

and the other one from Data are intended for this, to open an existing keystore if it follows the standard described in the main Ethereum (Geth) repo

@6epreu
Copy link
Author

6epreu commented Feb 27, 2018

Im using exactly this constructor right now.
My flow is create KeystoreParamsV3 and store it as a json in user defaults.
Then Im parsing all wallets from son to objects (KeystoreParamsV3 ) back. And now I want to create keystone and I obligated to transform KeystoreParamsV3 to json and the use your constructor.

Im just trying to advise what could be good to use.

@shamatar
Copy link
Contributor

Oh, I see what you mean.

Yes, should be added, I've made a note

@shamatar
Copy link
Contributor

shamatar commented Apr 5, 2018

Included in 0.4.0

@shamatar shamatar closed this as completed Apr 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants