Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SelectFieldsTableView? #92

Open
rodolakis opened this issue Feb 25, 2024 · 1 comment
Open

Refactor SelectFieldsTableView? #92

rodolakis opened this issue Feb 25, 2024 · 1 comment
Assignees
@rodolakis
Labels
enhancement New feature or request
Milestone
v1.1

Comments

@rodolakis
Copy link
Collaborator

@prjemian:

I believe you are the one who came up with the logic for the checkboxes in SelectFieldsTableView: the self.selections attribute is not encapsulated. Do you remember why? I keep staring at it and can't really tell if it matters or not. It just bothers me a bit, for consistency-sake.
@rodolakis rodolakis added the enhancement New feature or request label Feb 25, 2024
@rodolakis rodolakis added this to the v2.0 milestone Feb 25, 2024
@rodolakis rodolakis self-assigned this Feb 25, 2024
@prjemian
Copy link
Collaborator

Looks like an oversight to me. We should make it consistent. Gemviz has this same situation.

@rodolakis rodolakis modified the milestones: v2.0, v1.1 Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodolakis rodolakis

Labels
enhancement New feature or request
Projects
mdaviz
Status: Upgrades
Milestone
v1.1
Development

No branches or pull requests
2 participants
@prjemian @rodolakis