Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPCS matching radius fix #212

Closed
kkotysz opened this issue Oct 16, 2024 · 3 comments
Closed

CPCS matching radius fix #212

kkotysz opened this issue Oct 16, 2024 · 3 comments
Assignees
Labels
bug Something isn't working critical Critical bugs in need of immediate fix. help needed Extra attention is needed quick-fix needed

Comments

@kkotysz
Copy link
Collaborator

kkotysz commented Oct 16, 2024

Change fixed matching radius == 2 arcsec to more flexible parameter tied to sigma of astrometric solution. Examples of well reduced datums: one matched and one not matched below.

TOI is conveniently marked in .dat file with 999999 object number.

@kkotysz kkotysz added bug Something isn't working help needed Extra attention is needed critical Critical bugs in need of immediate fix. quick-fix needed labels Oct 16, 2024
@wyrzykow
Copy link
Contributor

The idea is that we will use the actual matching radius based on the Ra-Dec cleaning we do at the very beginning of CPCS. We will then use sqrt(deltaRA^2+deltaDec^2) x 1.5 as the matching radius when identifying a target in the get_results method. Simple fix, but requires attention in coding.

@wyrzykow
Copy link
Contributor

Coded, added to cpcs-test. Matching radius is found from Ra-Dec match and is used for target identification. I use 2x sigma_ra_dec, but we can then see if that is too large.

Match_dist is stored in the db by the uploader, but then its value is updated after found by ra-dec. We store match_dist in arcseconds. Note the db contains a typo in the column name: match_distans, but it has to stay.

Still need to test it for Gaia19eyy.

@wyrzykow
Copy link
Contributor

Tested on Gaia19eyy.
Computed the sigma of ra_dec to 2.6:
from cpcs log:
-matching_dist used: 5.220130901027017
Target search: minimum distance found of 2.1321952094990215 arcsec

image

Works! Installed on cpcs-test. Can be moved to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Critical bugs in need of immediate fix. help needed Extra attention is needed quick-fix needed
Projects
None yet
Development

No branches or pull requests

4 participants