Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read method default implementation for requests only accepts a FilterRequest #149

Closed
alelom opened this issue Oct 15, 2019 · 0 comments · Fixed by #151
Closed

Read method default implementation for requests only accepts a FilterRequest #149

alelom opened this issue Oct 15, 2019 · 0 comments · Fixed by #151
Assignees
@alelom
Labels
severity:medium Slows progress, but workaround is possible type:compliance Non-conforming to code guidelines
Milestone
BHoM 3.0 β MVP

Comments

@alelom
Copy link
Member

alelom commented Oct 15, 2019 •
edited
Loading

Broken rules:

The Read default implementation for requests only accepts FilterRequests. This is wrong and should accept IRequest instead.

This does not allow for correct implementation of IRequest as happens in e.g. Revit: BHoM/Revit_Toolkit#364

This chains with another issue: Pull does nothing if specified request is not a FilterRequest.

Suggestions to restore compliance:

Implement another Read overload with IRequest as paramter.
@alelom alelom added severity:critical No workaround exists. Essential to continue type:compliance Non-conforming to code guidelines labels Oct 15, 2019
@alelom alelom added this to the BHoM 3.0 β MVP milestone Oct 15, 2019
@alelom alelom self-assigned this Oct 15, 2019
@alelom alelom mentioned this issue Oct 15, 2019
Closed
@ZiolkowskiJakub ZiolkowskiJakub mentioned this issue Oct 15, 2019
Closed
@alelom alelom added severity:medium Slows progress, but workaround is possible and removed severity:critical No workaround exists. Essential to continue labels Oct 15, 2019
@alelom alelom mentioned this issue Oct 25, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alelom alelom

Labels
severity:medium Slows progress, but workaround is possible type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging a pull request may close this issue.

BHoM_Adapter - refactoring - Level 3 changes BHoM/BHoM_Adapter
1 participant
@alelom