You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Protected Abstract CRUD Method UpdateProperty could be made private, and renamed/refactored to reflect its use, which is to update the tags.
Reasons
The UpdateProperty method is actually not really used by most of the adapters.
It's used only to update the tags
It's never called directly through the dedicated Grasshopper component
However, it's necessary for the Replace method to work, because it's used to update the tags.
--> People implementing the adapters need to implement this if they want to use the tag system.
--> It would be clearer and simplify life for people if we reduced the scope of the method, limiting it to updating the tags, hence it should be renamed UpdateTags instead.
The corresponding Public Adapter Method could be removed as it's not used at all by anyone; arguably the Push should already take care of Updating Properties.
The text was updated successfully, but these errors were encountered:
alelom
changed the title
BHoM_Adapter: refactoring-UpdateProperty-make private and limit to update tags
BHoM_Adapter: refactoring-UpdateProperty (CRUD)-make private and limit to update tags
Jul 3, 2019
Proposed change
The Protected Abstract CRUD Method
UpdateProperty
could be made private, and renamed/refactored to reflect its use, which is to update the tags.Reasons
UpdateProperty
method is actually not really used by most of the adapters.UpdateTags
instead.The corresponding Public Adapter Method could be removed as it's not used at all by anyone; arguably the Push should already take care of Updating Properties.
The text was updated successfully, but these errors were encountered: