Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_Adapter: refactoring-UpdateProperty (CRUD)-make private and limit to update tags #87

Closed
Tracked by #84
alelom opened this issue May 24, 2019 · 0 comments · Fixed by #151
Closed
Tracked by #84
Assignees

Comments

@alelom
Copy link
Member

alelom commented May 24, 2019

Proposed change

The Protected Abstract CRUD Method UpdateProperty could be made private, and renamed/refactored to reflect its use, which is to update the tags.

Reasons

  • The UpdateProperty method is actually not really used by most of the adapters.
  • It's used only to update the tags
  • It's never called directly through the dedicated Grasshopper component
  • However, it's necessary for the Replace method to work, because it's used to update the tags.
    • --> People implementing the adapters need to implement this if they want to use the tag system.
    • --> It would be clearer and simplify life for people if we reduced the scope of the method, limiting it to updating the tags, hence it should be renamed UpdateTags instead.

The corresponding Public Adapter Method could be removed as it's not used at all by anyone; arguably the Push should already take care of Updating Properties.

@alelom alelom self-assigned this May 24, 2019
@alelom alelom changed the title BHoM_Adapter: refactoring-UpdateProperty-make private and limit to update tags BHoM_Adapter: refactoring-UpdateProperty (CRUD)-make private and limit to update tags Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant