Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial_Engine: IsVertical methods #1199

Open
rwemay opened this issue Sep 13, 2019 · 6 comments
Open

Spatial_Engine: IsVertical methods #1199

rwemay opened this issue Sep 13, 2019 · 6 comments
Assignees
Labels
type:feature New capability or enhancement

Comments

@rwemay
Copy link
Member

rwemay commented Sep 13, 2019

Description:

Add is vertical methods for Element1D and possibly Element2D(?) Checking whether a line or a planar surface based object is vertical is something that recurs in many disciplines, and there are already some methods (e.g. structural bar). Could also come in handy for the 'tilt' methods below. #1197

To be merged first: #1316

@rwemay rwemay added the type:feature New capability or enhancement label Sep 13, 2019
@pawelbaran pawelbaran changed the title Geometry_Engine: IsVertical methods Common_Engine: IsVertical methods Sep 13, 2019
@pawelbaran
Copy link
Member

Sounds good - changed the header to Common_Engine as it should work on IElements I think.

@FraserGreenroyd
Copy link
Contributor

@pawelbaran @LMarkowski is this likely to be actioned next week? If not we should push this to 3.1?

Also is Common_Engine the right engine to place this, I thought all common engine methods were migrating out?

@FraserGreenroyd FraserGreenroyd removed their assignment Nov 29, 2019
@pawelbaran
Copy link
Member

Yeah, IElements are meant to migrate to the Geometry universe altogether - #1316 should go first I think. I will update the Milestone and title.

@pawelbaran pawelbaran changed the title Common_Engine: IsVertical methods Geometry_Engine: IsVertical methods Nov 29, 2019
@kThorsager
Copy link
Contributor

Can note that this is partly handled in #1402 by moving some functionality from Structure_Engine to Geometry. Will however not fix IElement things before #1316

@pawelbaran
Copy link
Member

@kThorsager is that issue still relevant?

@kThorsager
Copy link
Contributor

I haven't fixed it, so would suppose so.

But IElement solutions should be in Spatial_Engine, but unsure if methods for IGeometries are requested too

@pawelbaran pawelbaran removed their assignment Sep 4, 2020
@al-fisher al-fisher changed the title Geometry_Engine: IsVertical methods Spatial_Engine: IsVertical methods Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

No branches or pull requests

5 participants