Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Strange behaviour from Offset #1868

Closed
kThorsager opened this issue Jun 29, 2020 · 3 comments
Closed

Geometry_Engine: Strange behaviour from Offset #1868

kThorsager opened this issue Jun 29, 2020 · 3 comments
Labels
type:bug Error or unexpected behaviour

Comments

@kThorsager
Copy link
Contributor

Description:

For example, this outline kind of explodes out, and I'm sure there are more edge-cases which would be nice to resolve
image

@LMarkowski think you wrote most of it, unsure of the extent of this problem

Steps to reproduce:

Expected behaviour:

Test file(s):

https://burohappold.sharepoint.com/:u:/s/BHoM/EYRnedr3sFdIkVOPMxrHYtQBGoxnEB_SE-MMd5ZQk89Skw?e=8iLWhP

@kThorsager kThorsager added the type:bug Error or unexpected behaviour label Jun 29, 2020
@LMarkowski
Copy link
Contributor

Hi @kThorsager,
As said in the initial PR (#1314) , I am aware that this method is not perfect. The idea behind it was to create a method working for the most of typical project cases. Therefore offset works best for convex shapes. For concave it can produce errors as in your case, but it should throw a relevant warning. I've listed my concerns and ideas for improvement in this issue #1333, but honestly I can't tell if I'll be capable of implementing them any soon.
Sorry for not being very helpful. 🙈 If there is a need to have a more error-proof offset method I can try to find some time to give it another try. But it may require rewriting the method from the top down.

@kThorsager
Copy link
Contributor Author

Ah, had missed that one, but my case is not critical and I can understand that this is not a simple method even now.

So mostly liked to capture this, to be picked up at some point 👍

@FraserGreenroyd
Copy link
Contributor

Closing as duplicate of #1333 which captures more information about offset issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
Status: Completed
Development

No branches or pull requests

3 participants