Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISetGeometry deleted #3314

Open
johannaisak opened this issue Mar 11, 2024 · 3 comments
Open

ISetGeometry deleted #3314

johannaisak opened this issue Mar 11, 2024 · 3 comments
Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement

Comments

@johannaisak
Copy link
Contributor

Description:

I use this method all the time to manipulate analysis models. Please can we reinstate it? Or alternatively a specific SetGeometry for Bars?

image

@johannaisak johannaisak added type:bug Error or unexpected behaviour type:feature New capability or enhancement labels Mar 11, 2024
@FraserGreenroyd
Copy link
Contributor

Hi @johannaisak , based on this PR which removed ISetGeometry, the method was calling to a SetGeometry method via the TryRunExtension (see below/files changed on the link).

image

This suggests that there is a method for SetGeometry that will accept a Bar if it was working previously. I've tried looking for it but I can't work out which one it would be, so my recommendation would be to drag right out of a bar component and let the wire search find it for you (as it should come up with the option that accepts a Bar first).

@johannaisak
Copy link
Contributor Author

Thanks @FraserGreenroyd you're right this is the component, searching for "SetGeometry el.." brings it up. Not sure why the component calls it ISetGeometry, the search result just says SetGeometry. It would be great if this search result could come up if you search for "SetGeometry bar" as well but perhaps that is not possible?

image

@FraserGreenroyd
Copy link
Contributor

It's not possible right now, but it could be as part of our ongoing UX improvements this year in line with our settings engine and other changes we want to bring in to the search model to help people find the right component in the large library of components we now have. There may be an argument for adding SetGeometry(this Bar bar, Curve curve) to the Structure Engine which can call this IElement1D set geometry method to improve the UX as a stop-gap, but I know @IsakNaslundBh has had reservations against doing so in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants