Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: IsRigidTransformation query returns false for reflection #3355

Open
pawelbaran opened this issue Jun 11, 2024 · 0 comments · May be fixed by #3356
Open

Geometry_Engine: IsRigidTransformation query returns false for reflection #3355

pawelbaran opened this issue Jun 11, 2024 · 0 comments · May be fixed by #3356
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@pawelbaran
Copy link
Member

Description:

As in the title, reflection is considered a non-rigid transformation in BHoM - looking at the code, it seems to be a typo in line below, Math.Abs should be targeted at determinant, not 1-determinant.

return multiplied.IsEqual(identity, tolerance) && Math.Abs(1 - rotation.Determinant()) <= tolerance;

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Jun 11, 2024
@pawelbaran pawelbaran self-assigned this Jun 11, 2024
@pawelbaran pawelbaran linked a pull request Jun 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant