Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the new version of the CreateObject component #176

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Update to the new version of the CreateObject component #176

merged 1 commit into from
Nov 1, 2019

Conversation

adecler
Copy link
Member

@adecler adecler commented Oct 29, 2019

NOTE: Depends on

BHoM/BHoM_UI#147

Issues addressed by this PR

See BHoM/BHoM_UI#147 for more details

@adecler adecler self-assigned this Oct 29, 2019
@adecler adecler added the type:feature New capability or enhancement label Oct 29, 2019
@adecler adecler added this to the BHoM 3.0 β MVP milestone Oct 29, 2019
michaldengusiak
michaldengusiak approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@michaldengusiak michaldengusiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can pull XML using Dynamo
image

epignatelli
epignatelli approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@epignatelli epignatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all works fine.

The only thing I noticed is that when you drop the component on the canvas it takes a while to load.
Although, I am not sure it was not doing it before.

@adecler adecler merged commit 989fccc into master Nov 1, 2019
@adecler adecler deleted the BHoM_UI-#124-NewCreateObjectComponent branch November 1, 2019 10:06
@adecler
Copy link
Member Author

adecler commented Nov 1, 2019

@epignatelli , the long time it takes is only on the first component. This is because there is no way (I could find) to load the BHoM when Dynamo is loading so it is done when the first component is dropped on the canvas.

This was referenced Dec 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epignatelli epignatelli epignatelli approved these changes

@michaldengusiak michaldengusiak michaldengusiak approved these changes

@ZiolkowskiJakub ZiolkowskiJakub Awaiting requested review from ZiolkowskiJakub

@al-fisher al-fisher Awaiting requested review from al-fisher

Assignees

@adecler adecler

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
BHoM 3.0 β MVP
Development

Successfully merging this pull request may close these issues.
3 participants
@adecler @michaldengusiak @epignatelli