Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File_Adapter/Filing_Toolkit plan of action #70

Open
4 of 9 tasks
alelom opened this issue Oct 12, 2020 · 1 comment
Open
4 of 9 tasks

File_Adapter/Filing_Toolkit plan of action #70

alelom opened this issue Oct 12, 2020 · 1 comment
Assignees

Comments

@alelom
Copy link
Member

alelom commented Oct 12, 2020

We want to make sure that no redundant functionality exists between File_Adapter and Filing_Toolkit.

In order to do that, the plan is the following:

  • 1) Open source the Filing_Toolkit.
    • 1.0) Move the Filing_Toolkit to open source. This will bring the "reach" of the Filing_Toolkit at the same extension of the File_Adapter.
    • 1.1) Update the installer
    • 1.2) Update the CI
  • 2) Merge the File_Adapter into the Filing Toolkit. This means to to the following actions at the same time:
    • 2.0) Add a new constructor to the Filing_Adapter that mirrors the constructor of the File_Adapter (string defaultDirectory, string defaultFilename).
    • 2.1) Rename the Filing_Toolkit to File_Toolkit. This will result into a new repo called File_Toolkit with a namespace starting in BH.oM.Adapters.File etc.
    • 2.2) At the same time, delete the File_Adapter from the BHoM_Adapter repo.
    • 2.3) Ensure that Versioning captures the old namespace for the FIle_Adapter (BH.Adapter.FileAdapter) and maps it to the new namespace.

@al-fisher @IsakNaslundBh

@alelom alelom self-assigned this Oct 12, 2020
@al-fisher
Copy link
Member

Looks good @alelom . We will need additional steps above at the point of renaming of Filing_Toolkit (to File) - to update the Installer and CI also as Filing is included in deployment.

This is in addition to the Installer needing updating as part of the open sourcing procedure too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants