You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We want to make sure that no redundant functionality exists between File_Adapter and Filing_Toolkit.
In order to do that, the plan is the following:
1) Open source the Filing_Toolkit.
1.0) Move the Filing_Toolkit to open source. This will bring the "reach" of the Filing_Toolkit at the same extension of the File_Adapter.
1.1) Update the installer
1.2) Update the CI
2) Merge the File_Adapter into the Filing Toolkit. This means to to the following actions at the same time:
2.0) Add a new constructor to the Filing_Adapter that mirrors the constructor of the File_Adapter (string defaultDirectory, string defaultFilename).
2.1) Rename the Filing_Toolkit to File_Toolkit. This will result into a new repo called File_Toolkit with a namespace starting in BH.oM.Adapters.File etc.
2.2) At the same time, delete the File_Adapter from the BHoM_Adapter repo.
2.3) Ensure that Versioning captures the old namespace for the FIle_Adapter (BH.Adapter.FileAdapter) and maps it to the new namespace.
Looks good @alelom . We will need additional steps above at the point of renaming of Filing_Toolkit (to File) - to update the Installer and CI also as Filing is included in deployment.
This is in addition to the Installer needing updating as part of the open sourcing procedure too
We want to make sure that no redundant functionality exists between File_Adapter and Filing_Toolkit.
In order to do that, the plan is the following:
string defaultDirectory, string defaultFilename
).File_Toolkit
with a namespace starting inBH.oM.Adapters.File
etc.BH.Adapter.FileAdapter
) and maps it to the new namespace.@al-fisher @IsakNaslundBh
The text was updated successfully, but these errors were encountered: