Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robot_Toolkit: Clean up section property management #286

Closed
IsakNaslundBh opened this issue Dec 10, 2019 · 1 comment
Closed

Robot_Toolkit: Clean up section property management #286

IsakNaslundBh opened this issue Dec 10, 2019 · 1 comment
Assignees
@IsakNaslundBh
Labels
type:compliance Non-conforming to code guidelines
Milestone
BHoM 3.1 β MVP

Comments

@IsakNaslundBh
Copy link
Contributor

Broken rules:

The create/read/convert of section properties is spread over multiple files across adapter and or engine. As all of them actually are doing comcalls through objects they should all be moved to the adapter. File name and division also need to be cleaned up to make thigns easier to find.

Suggestions to restore compliance:

See above.
@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Dec 10, 2019
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.1 β MVP milestone Dec 10, 2019
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 7, 2020
@IsakNaslundBh
Copy link
Contributor Author

closed by #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.1 β MVP
Development

No branches or pull requests
1 participant
@IsakNaslundBh