Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robot_Toolkit: Cladding panels property name hardcoded #321

Closed
rwemay opened this issue Feb 21, 2020 · 0 comments · Fixed by #310
Closed

Robot_Toolkit: Cladding panels property name hardcoded #321

rwemay opened this issue Feb 21, 2020 · 0 comments · Fixed by #310
Labels
type:bug Error or unexpected behaviour

Comments

@rwemay
Copy link
Member

rwemay commented Feb 21, 2020

Description:

The Create Panel method calls to set a cladding label based on the property name, and relies on the user inputting type-strong 'One-way X' names etc for the method to work.

Steps to reproduce:

Try to push cladding panels with an incorrect name.

Expected behaviour:

LoadingPanelProperty loading properties should be used to derive the name within the toolkit.

Test file(s):
@rwemay rwemay added the type:bug Error or unexpected behaviour label Feb 21, 2020
@rwemay rwemay mentioned this issue Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compliance Update and Enable Update Panels BHoM/Robot_Toolkit
1 participant
@rwemay