Fix bug for Modify methods on an object that contains 'List' in its type

adecler · adecler · commit d502d2919a0e · 2024-11-26T17:14:57.000Z
diff --git a/CodeComplianceTest_Engine/Query/Checks/IsExtensionMethod.cs b/CodeComplianceTest_Engine/Query/Checks/IsExtensionMethod.cs
@@ -55,7 +55,7 @@ public static Span IsExtensionMethod(this MethodDeclarationSyntax node)
             var parameters = node.ParameterList.Parameters;
             if (parameters.Count > 0 && !m_systemTypes.Contains(parameters[0].Type.ToString().ToLower()))
             {
-                if (Regex.Match(parameters[0].Type.ToString(), $"(List|IEnumerable|Dictionary)").Success)
+                if (Regex.Match(parameters[0].Type.ToString(), $"(List|IEnumerable|Dictionary)<").Success)
                 {
                     var typeOptions = parameters[0].Type.ToString().Split('<')[1].Split('>')[0].Split(',');
                     foreach(var t in typeOptions)

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public static Span IsExtensionMethod(this MethodDeclarationSyntax node)`
`55`	`55`	`var parameters = node.ParameterList.Parameters;`
`56`	`56`	`if (parameters.Count > 0 && !m_systemTypes.Contains(parameters[0].Type.ToString().ToLower()))`
`57`	`57`	`{`
`58`		`- if (Regex.Match(parameters[0].Type.ToString(), $"(List\|IEnumerable\|Dictionary)").Success)`
	`58`	`+ if (Regex.Match(parameters[0].Type.ToString(), $"(List\|IEnumerable\|Dictionary)<").Success)`
`59`	`59`	`{`
`60`	`60`	`var typeOptions = parameters[0].Type.ToString().Split('<')[1].Split('>')[0].Split(',');`
`61`	`61`	`foreach(var t in typeOptions)`