Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission RPC fails due to a change with the display_errors setting. #5998

Open
lfield opened this issue Jan 9, 2025 · 1 comment · May be fixed by #6001
Open

Submission RPC fails due to a change with the display_errors setting. #5998

lfield opened this issue Jan 9, 2025 · 1 comment · May be fixed by #6001

Comments

@lfield
Copy link
Contributor

lfield commented Jan 9, 2025

Describe the bug

The RPC command cmd=batch_files from get_output.php fails with the 1.4.7 release.
The client receives the error "zipfile.BadZipFile: File is not a zip file" due to the file containing a HTML response. e.g.

<br />
<b>Warning</b>:  filesize(): stat failed for /boincdata/boinc/project/lhcathome/html/cache/boinc_batch_gzCHsF.zip in <b>/boincdata/boinc/project/lhcathome/html/inc/util.inc</b> on line <b>1092</b><br />
<br />
<b>Warning</b>:  readfile(/boincdata/boinc/project/lhcathome/html/cache/boinc_batch_gzCHsF.zip): Failed to open stream: No such file or directory in <b>/boincdata/boinc/project/lhcathome/html/inc/util.inc</b> on line <b>1094</b><br />
<br />
<b>Warning</b>:  unlink(/boincdata/boinc/project/lhcathome/html/cache/boinc_batch_gzCHsF.zip): No such file or directory in <b>/boincdata/boinc/project/lhcathome/html/user/get_output.php</b> on line <b>118</b><br />

This issue seems to be caused by the setting ini_set('display_errors', true); in util.inc

Steps to reproduce

No response

Expected behavior

No response

Screenshots

No response

System information

No response

Additional context

No response

@davidpanderson
Copy link
Contributor

util.inc doesn't currently call ini_set('display_errors', true);

for job-submission stuff it's generally better to see the errors, so they can be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants