Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing the python implementation #3

Open
gabor-boros opened this issue Jul 5, 2021 · 3 comments
Open

Replacing the python implementation #3

gabor-boros opened this issue Jul 5, 2021 · 3 comments

Comments

@gabor-boros
Copy link

gabor-boros commented Jul 5, 2021

We all know the reason why this tool was created: the Python implementation has a lot of issues and not the most convenient to maintain.

How do you feel about implementing the same flags for this tools to it could be a drop-in replacement of the Python implementation that we could simply purge?

I'm happy to help with this!

Cc @MrBoombastic

@MrBoombastic
Copy link
Member

I fowarded this idea to @VenomPCPL. I think that is easy to do, but I don't know if flags should be the same. I personally don't like some in Python driver. Maybe adding aliases is a solution? I don't know. We will see.

I will keep this issue opened. It's interesting topic.

@gabor-boros
Copy link
Author

Thank you for taking care and forwarding @MrBoombastic!

I think that is easy to do

Yeah, I think too and, as I mentioned, I'm happy to help with that. Mainly I wanted to discuss as per this recommendation.

I personally don't like some in Python driver.

Me neither. Also, I think it is a bad thing that the import/export/repl/restore is living in a client/driver.

Maybe adding aliases is a solution? I don't know. We will see.

That's a good idea, as I can see, most of the aliases are in place, though I didn't compare everything. Although most of the flags are there for the import and export I found some that were a fundamental part of the Python implementation, but I didn't find them here.

The export sub-command

  • --format
  • --fields
  • --delimiter
  • --clients -- this one is probably not needed

The import sub-command

If I'm right the current import command is doing what the restore command, and partially, import did in the Python client. This means that the two could be combined.

  • --force
  • --shards
  • --replicas
  • -d -- import from a directory
  • --format
  • --pkey
  • --delimiter
  • --custom-header
  • --no-header
  • --clients -- this one is probably not needed

@MrBoombastic
Copy link
Member

If you want to add some features, you can open a pull request. We are currently doing nothing in this tool, so any collaboration is much appreciated.
We are happy that somebody found this tool useful and wants to help us. Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants