Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in STATUS: RUNNING dependencies #1435

Closed
kinow opened this issue Oct 16, 2024 · 6 comments
Closed

Possible bug in STATUS: RUNNING dependencies #1435

kinow opened this issue Oct 16, 2024 · 6 comments
Assignees
Labels
bug Something isn't working discussion The issue is created to keep track a discussion working on Someone is working on it

Comments

@kinow
Copy link
Member

kinow commented Oct 16, 2024

In GitLab by @franra9 on Oct 16, 2024, 15:52

Hello @dbeltrankyl and @kinow,

Autosubmit Version

4.1.10

Expid affected(If applicable)

a1q3

Which task has issues? Where is the log(If applicable)

  • Full_name: does not apply

  • Log_Path: does not apply

Summary

DN is submitted on SIM submission and not on running despite the jobs.yml does not say so.

Steps to reproduce

Try copying a1q3 but there is some issue before.

What is the current bug behavior?

DN submitted on SIM on submission instead of Running (SIM is on the queue but DN already running)

What is the expected correct behavior?

DN submitted on SIM on running instead.

Relevant logs and/or screenshots(if applicable)

Job a1q3_20200101_fc0_1_SIM is QUEUING
Checking 1 jobs for platform LUMI-LOGIN
Job a1q3_20200101_fc0_1_1_DN is RUNNING
(...)
  DN:
    CHECK: on_submission
    DEPENDENCIES:
      APP_ENERGY_ONSHORE-1:
        SPLITS_FROM:
          '0':
            SPLITS_TO: '%JOBS.DN.SPLITS%'
      DN:
        SPLITS_FROM:
          all:
            SPLITS_TO: previous
      REMOTE_SETUP:
        STATUS: COMPLETED
      SIM:
        STATUS: RUNNING
(...)

Any other relevant information(if applicable)

()

@kinow
Copy link
Member Author

kinow commented Oct 16, 2024

In GitLab by @dbeltrankyl on Oct 16, 2024, 15:54

But it didn't happen until now, no?

Can you try to remove the

REMOTE_SETUP:
        STATUS: COMPLETED # <- this

@kinow
Copy link
Member Author

kinow commented Oct 18, 2024

In GitLab by @franra9 on Oct 18, 2024, 11:49

Hi @dbeltrankyl , you are right this is a misconfiguration in the jobs.yml

I don't know if this did not happen or we just didn't see it.

in any case,

Does it make sense though to have an OR instead of an AND here? I mean, tell me if what I say is not correct, but it seems that in this case AS is proceeding with the downstream execution when not all the conditions described in JOBS are fulfilled. Maybe you can explain to me how this works exactly via slack if you wish.

@kinow
Copy link
Member Author

kinow commented Oct 18, 2024

In GitLab by @franra9 on Oct 18, 2024, 16:29

mentioned in merge request digital-twins/de_340-2/workflow!322

@kinow
Copy link
Member Author

kinow commented Oct 23, 2024

In GitLab by @dbeltrankyl on Oct 23, 2024, 15:08

Hello @franra9

I'll check this today/tomorrow.

The behavior should/will(wip) be the one described in #1316.

When the key '?' (WIP) is not introduced, the dependencies will always be an AND.

Currently, they're always an AND so

AS is proceeding with the downstream execution when not all the conditions described in JOBS are fulfilled. Maybe you can explain to me how this works exactly via slack if you wish.

This shouldn't be the case

@kinow
Copy link
Member Author

kinow commented Oct 28, 2024

In GitLab by @dbeltrankyl on Oct 28, 2024, 09:31

mentioned in commit e787950

@kinow
Copy link
Member Author

kinow commented Oct 28, 2024

In GitLab by @franra9 on Oct 28, 2024, 09:52

🎉 great @dbeltrankyl ! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discussion The issue is created to keep track a discussion working on Someone is working on it
Projects
None yet
Development

No branches or pull requests

2 participants