The current source code of Autosubmit has many underlying issues that can be easily detected by linters.

It does. If you ever open autosubmit.py, with its over 5K or 6K lines, it's simply impossible to read the code with the IDE without ignoring the warnings (I have to manually disable code inspection for that file).

It will be nice to solve them to prevent future bugs and keep tracking them in future releases as part of our development process.

+1, and have CICD to check for those, like the Workflow team is doing. @mcastril something that could be included for the September extraordinary team meeting agenda, IMO. We don't need to fix all at one, but maybe during August or December, when things are calmer, we could fix a bunch, and then the next chance we have we fix a little more...

Thanks Luiggi!

In GitLab by @dbeltrankyl on Aug 28, 2024, 10:30

Thanks Luiggi,

The IDE (pycharm) can solve a few of these issues with some inbuilt tools, I've used it a couple of times. I usually don't use it in a merge request because it makes modifications to all code and complicates the code review.

Maybe we should start by using that tool in a separate merge request, merge it, and we can include a procedure to run it in each new merge requests as it will only fix the new code added and doesn't complicate the code review

In GitLab by @dbeltrankyl on Aug 28, 2024, 15:15

mentioned in merge request autosubmit4-config-parser!9

In GitLab by @LuiggiTenorioK on Aug 28, 2024, 15:41

Maybe we should start by using that tool in a separate merge request, merge it, and we can include a procedure to run it in each new merge requests as it will only fix the new code added and doesn't complicate the code review

+1

The IDE (pycharm) can solve a few of these issues with some inbuilt tools, I've used it a couple of times. I usually don't use it in a merge request because it makes modifications to all code and complicates the code review.

Indeed, Ruff also can fix some of them "safely". I prefer to use Ruff since it also includes the code formatter and rules from other linters. Also, it is used in other projects in ES (like the one presented by Bruno and Aina) and works on different IDEs (VSCode and Pycharm as well).

In GitLab by @LuiggiTenorioK on Sep 2, 2024, 14:12

mentioned in issue autosubmit-api#87

This is something we can enlist Erick to help with. 👍