You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure if that function is used, I am in the middle of a review for @VindeeRBSC-ES/autosubmit-config-parser#66 when I saw that a function that Erick was changing could also have types added.
Doing so, I saw some warnings, and following them I saw these lines in the Autosubmit code:
I intentionally cut the code where the root_dir (expected to be a Path via type hints) is used with /. That won't work if a string is passed, as Autosubmit is doing.
My IDE found other usages fo ini_to_yaml and those were correctly passing a Path. My guess is that either that code is not used by users, or just not used at all. So we need to either fix it, or delete if the code is not accessible.
The text was updated successfully, but these errors were encountered:
Not sure if that function is used, I am in the middle of a review for @VindeeR BSC-ES/autosubmit-config-parser#66 when I saw that a function that Erick was changing could also have types added.
Doing so, I saw some warnings, and following them I saw these lines in the Autosubmit code:
autosubmit/autosubmit/autosubmit.py
Lines 1159 to 1160 in b95b91f
Note that the first argument to
ini_to_yaml
is the result ofjoin
, which is a string.While in the Autosubmit Config Parser we have:
https://github.com/BSC-ES/autosubmit-config-parser/blob/169b1eb48eeb494a760a0d4d685d7e756b48a701/autosubmitconfigparser/config/configcommon.py#L2505C21-L2519
I intentionally cut the code where the
root_dir
(expected to be aPath
via type hints) is used with/
. That won't work if a string is passed, as Autosubmit is doing.My IDE found other usages fo
ini_to_yaml
and those were correctly passing aPath
. My guess is that either that code is not used by users, or just not used at all. So we need to either fix it, or delete if the code is not accessible.The text was updated successfully, but these errors were encountered: