-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
N-Dim Blobs vs Datum #2152
Comments
Yes, |
Actually I vote for the deprecation of A The one responsibility of Fleshing out these ideas will take a bit of work. We'll try to come up with a coherent plan and dedicate an issue to it to guide our own and community development. Thanks for your interest in making this better. |
Right, I did not mean to suggest that we should necessarily keep around |
Datum, which contains encoded data is the best thing suitable for OpenCV-based online image augmentation, so keeping it is good idea :) |
Thanks all for the replies. Seems like a sensible direction to me. So based on the discussion above I think I see a way forward to move extract_features over to n-dim blobs. Since Datum looks to be kept around for image blobs and their transformations, also support non-image n-dim feature blobs by doing a bit of protobuf reflection on message to determine if it is a Datum or a Blob, and then handle it accordingly. Since shelhamer says will devote an issue to fleshing this all out I'll close this one. |
So I see the Datum message is still hard-wired for channels/width/height. There is a fair bit of code still coupled to that such as data transformer. I'd expect the way forward is to update Datum to also have a repeated axis_dim property, and enforce in code that either channels/width/height is specified or axis_dims are specified but not both.
This question arose as I was looking at following up on shelhammer's suggestion here that extract_features should be updated for N-dim blobs.
Does anyone have some perspective on this? Perhaps a Brewer could weigh-in before I start down a path that is doomed because I don't understand something. Thanks in advance.
The text was updated successfully, but these errors were encountered: