Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate solvers by string type and separate source files #2890

Closed
shelhamer opened this issue Aug 9, 2015 · 0 comments
Closed

Separate solvers by string type and separate source files #2890

shelhamer opened this issue Aug 9, 2015 · 0 comments
Assignees
@ronghanghu
Labels
focus

Comments

@shelhamer
Copy link
Member

The solver_type field is a proto enum causing conflicts for concurrent development. This should be made a string as #1694 did for layer type.

The solvers are currently defined and implemented in monolithic hpp and cpp that make extension awkward. Each should be split into its own header and source.

After #2860 #2782 #2856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ronghanghu ronghanghu

Labels
focus
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shelhamer @ronghanghu