Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Device Input Path #12566

Closed
2 of 4 tasks
PolygonalSun opened this issue May 23, 2022 · 4 comments
Closed
2 of 4 tasks

User Device Input Path #12566

PolygonalSun opened this issue May 23, 2022 · 4 comments
Assignees
Labels
enhancement in progress Someone is currently working on this issue inputs L1 Level 1 Goal
Milestone

Comments

@PolygonalSun
Copy link
Contributor

PolygonalSun commented May 23, 2022

User Device Input Path

Tasks:

  • Milestone 1 – Full Pointer Support in Native

    • Update NativeInput to Handle New Pointers
    • Mouse Implementation
      • Win32
      • UWP
      • MacOS
      • Linux (X11)
    • Touch Implementation
      • Win32
      • UWP
      • iOS
      • Android
  • Milestone 2 – Build up Testing Platform (Tracked in Design Test Plan For Input #12661)

    • Create Test Environment with Necessary Mock Objects
    • Create Unit Tests to Test Input System on JS
    • Integrate Safari testing into CI
    • Convert Babylon Native to use Jest
    • Create Input Recorder (Removing from Milestone)
  • Milestone 3 – Performance and Stability Improvements (Tracked in Input Performance and Stability Improvements #12898)

    • Improve Input Perf (frame call reduction)
    • Clean up and flatten Input enum/file structure
    • Move Browser-Specific Logic into DeviceInputSystem for more uniform cross-browser experience
    • Implement Lazy Picking (Turn on/instantiate picking elements when picking is first explicitly used)
  • Milestone 4 – Keyboard Support in Native- Update NativeInput to Handle Keyboards: Pre-lim keyboard work is in draft PR

    • Update NativeInput to Handle Keyboard Input
    • Keyboard Implementation
      • Win32
      • UWP
      • Linux
      • MacOS
    • Add Testing for Keyboard (and focus, potentially)

Bugs:

@PolygonalSun
Copy link
Contributor Author

PolygonalSun commented May 23, 2022

Status as of 5/20:
Win32 Implemenation (Keyboard): In Draft PR: BabylonJS/BabylonNative#1042
UWP Implemenation (Keyboard): In Draft PR: BabylonJS/BabylonNative#1042
Linux Implemenation (Keyboard): Building Keycode Conversion Table
MacOS Implemenation (Keyboard): Investigating issue where event isn’t firing properly

pointerUpPredicate not working/unable to disable up pick (PR: #12524)
Multiple Canvases causing crash - User is attempting to produce repro

@thomlucc thomlucc added L1 Level 1 Goal in progress Someone is currently working on this issue labels May 23, 2022
@PolygonalSun PolygonalSun removed the bug label May 23, 2022
@PolygonalSun
Copy link
Contributor Author

PolygonalSun commented May 27, 2022

Status as of 5/27:
Create custom mock window object for testing input and events: Working on window, testing for missing logic
Create Unit Tests to Test Input System on JS: Started writing tests and finding all test cases

Win32 Implemenation (Keyboard): In Draft PR: BabylonJS/BabylonNative#1042
UWP Implemenation (Keyboard): In Draft PR: BabylonJS/BabylonNative#1042
Linux Implemenation (Keyboard): Building Keycode Conversion Table
MacOS Implemenation (Keyboard): Investigating issue where event isn’t firing properly

Multiple Canvases causing crash - User is attempting to produce repro

@PolygonalSun
Copy link
Contributor Author

Status as of 6/3:
Create custom mock window object for testing input and events: Identified object gaps, beginning environment implementation
Create Unit Tests to Test Input System on JS: Prototyped tests for baseline, will refine tests as environment implementation is completed

Win32 Implemenation (Keyboard): In Draft PR: BabylonJS/BabylonNative#1042
UWP Implemenation (Keyboard): In Draft PR: BabylonJS/BabylonNative#1042
Linux Implemenation (Keyboard): Building Keycode Conversion Table
MacOS Implemenation (Keyboard): Investigating issue where event isn’t firing properly

Multiple Canvases causing crash - User is attempting to produce repro

@thomlucc thomlucc added this to the 6.0 milestone Sep 21, 2022
@thomlucc
Copy link
Member

Closing as it is now tracked as a project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement in progress Someone is currently working on this issue inputs L1 Level 1 Goal
Projects
None yet
Development

No branches or pull requests

2 participants