Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings on excluded files #496

Closed
shacker opened this issue May 23, 2024 · 3 comments · Fixed by #501
Closed

Warnings on excluded files #496

shacker opened this issue May 23, 2024 · 3 comments · Fixed by #501

Comments

@shacker
Copy link

shacker commented May 23, 2024

My exclusion regexes are working fine, but I'm getting lots of warnings like:

WARNING: /path/to/file could not be accessed (no permissions to read?)

That's probably because I ran the script without sudo and some dirs are off-limits, but if I've excluded /path/to, it shouldn't even be looking at that path, so why the warning?

@mjurbanski-reef
Copy link
Contributor

Currently, exclusion happens after iteration of files, so it is indeed suboptimal.

This will likely also cause b2 CLI to return status code 1 (fail) even if inaccessible are skipped, which makes it not only annoying but a full fledged bug that has to be fixed.

@titus8
Copy link

titus8 commented May 30, 2024

This inspired me to add filtering the sys.stderr replacement I pass to SyncReport.

@shacker
Copy link
Author

shacker commented Jun 16, 2024

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants