Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage: Diff Checker Bot #545

Open
mitche50 opened this issue Jan 20, 2022 · 0 comments
Open

Coverage: Diff Checker Bot #545

mitche50 opened this issue Jan 20, 2022 · 0 comments
Labels

Comments

@mitche50
Copy link
Contributor

mitche50 commented Jan 20, 2022

When enabling the unclaimed rewards, an incorrect variable was used causing the bot to double count unclaimed rewards, over allocating funds. This was evident in the distribution rate being higher after enabling this feature, but was missed while auditing the release.

The rewards team should create a bot that runs each cycle and compares the distribution rates by comparing new_cycle_diff[token] / length_of_new_cycle to old_cycle_diff[token] / length_of_old_cycle

If these rates are outside of some defined margin (say 2% +-) then alert the team to this difference for investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant