Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendEvent could fail and cause unhandledrejection, which is unexpected for webpack dev overlay #11

Closed
JounQin opened this issue May 13, 2024 · 2 comments

Comments

@JounQin
Copy link

JounQin commented May 13, 2024

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @barbapapazes/plausible-tracker@0.5.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/@barbapapazes/plausible-tracker/dist/index.mjs b/node_modules/@barbapapazes/plausible-tracker/dist/index.mjs
index a682ac4..1910b54 100644
--- a/node_modules/@barbapapazes/plausible-tracker/dist/index.mjs
+++ b/node_modules/@barbapapazes/plausible-tracker/dist/index.mjs
@@ -30,7 +30,7 @@ function sendEvent(apiHost, payload, callback) {
     body: JSON.stringify(payload)
   }).then(() => {
     callback?.();
-  });
+  }).catch(() => {});
 }
 
 function createPayload(eventName, plausibleOptions, data, options) {

This issue body was partially generated by patch-package.

@JounQin
Copy link
Author

JounQin commented May 13, 2024

The request could fail on a lot of cases, such as incorrect configuration, client blocking, network error, etc.

@Barbapapazes
Copy link
Owner

Hey, thank you for your feedback! 🙌

I will update the tracker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants