Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialCard Shadow #433

Open
1 task
Boukri opened this issue Aug 13, 2021 · 10 comments
Open
1 task

MaterialCard Shadow #433

Boukri opened this issue Aug 13, 2021 · 10 comments

Comments

@Boukri
Copy link

Boukri commented Aug 13, 2021

🐛 Bug Report

Card shadow not showing

Expected behavior

As docs present =>
Elevation - The virtual distance along the z-axis. The value determines the importance of the content pesented in this view. The default value is 1.
But there's no shadow dropped

My Code

<ContentPage xmlns="http://xamarin.com/schemas/2014/forms"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" 
             xmlns:material="clr-namespace:XF.Material.Forms.UI;assembly=XF.Material"
             x:Class="LiteStock.Views.SellView" Title="بيع">
    <ContentPage.Content>
        <StackLayout>
            <material:MaterialCard CornerRadius="7" Margin="50" Elevation="8" HeightRequest="80" HorizontalOptions="FillAndExpand" VerticalOptions="FillAndExpand">
                <StackLayout>
                    <Label Text="hello"/>
                </StackLayout>
            </material:MaterialCard>
        </StackLayout>
    </ContentPage.Content>
</ContentPage>

Pic of result

XFerror

Version: 1.7.8

Platform:

  • 🤖 Android
@Boukri Boukri changed the title MaterialCard MaterialCard Shadow Aug 13, 2021
@bricefriha
Copy link
Contributor

Hi @Boukri,
Is it just on Android?

@Boukri
Copy link
Author

Boukri commented Aug 16, 2021

@bricefriha I don't have mac to test this in ios :/

@bricefriha
Copy link
Contributor

@bricefriha I don't have mac to test this in ios :/

No problem, I'll be testing this on iOS to see if this impact both platforms 😉

@Boukri
Copy link
Author

Boukri commented Aug 16, 2021

@bricefriha that's would be amazing!

@Boukri
Copy link
Author

Boukri commented Aug 21, 2021

@bricefriha I don't have mac to test this in ios :/

No problem, I'll be testing this on iOS to see if this impact both platforms 😉

Is there any news about this?

@bricefriha
Copy link
Contributor

@Boukri Nope sorry, I'm quite busy these days, I try to take a look at that tomorrow 😉

@Boukri
Copy link
Author

Boukri commented Aug 21, 2021

@Boukri Nope sorry, I'm quite busy these days, I try to take a look at that tomorrow 😉

Ok take your time 😁

@bricefriha
Copy link
Contributor

@Boukri So, I copy-pasted your code and it works on iOS seemingly, however on Android, I've had a better result than yours (even though it's still not great 😅). In the sense that I can see the card but the shadow is not there at all.

I'm currently working with a client on an app that uses this library and I'm not facing the issue, though.
However, I don't believe you did anything wrong, So I'm gonna take a look at this and let you know 😉

@Boukri
Copy link
Author

Boukri commented Aug 22, 2021

@Boukri So, I copy-pasted your code and it works on iOS seemingly, however on Android, I've had a better result than yours (even though it's still not great 😅). In the sense that I can see the card but the shadow is not there at all.

I'm currently working with a client on an app that uses this library and I'm not facing the issue, though.
However, I don't believe you did anything wrong, So I'm gonna take a look at this and let you know 😉

Thank you so much for your efforts, for this moment i changed the material card with just frame, in order to save my client and avoiding any UI issues. So I'll be waiting for your reply 😁

@bricefriha
Copy link
Contributor

@Boukri That's wise indeed, that's also what I did for one of the other issues 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants