Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Solaris & Illumos etc. (*easy* fix, code suggestion within) #1455

Open
jdrch opened this issue Dec 4, 2019 · 1 comment · May be fixed by #2039
Open

Add support for Solaris & Illumos etc. (*easy* fix, code suggestion within) #1455

jdrch opened this issue Dec 4, 2019 · 1 comment · May be fixed by #2039
Labels
feature request help wanted seems abandoned rattle the cage, and close if nobody wants to keep it going

Comments

@jdrch
Copy link

jdrch commented Dec 4, 2019

Solaris and Illumos use Bash as the default shell. However, currently bash-it does not work as expected on them.

This can be fixed as described, tested, and confirmed here.

Here's what I suggest:

  • In install.sh, check for $0STYPE of solaris*
  • If $0STYPE is solaris*, then:
    • Backup ~/.profile to ~/.profile.bak
    • Comment out all uncommented lines in ~/.profile
    • Add the following lines to ~/.profile:
# if running bash
if [ -n "$BASH_VERSION" ]; then
    # include .bashrc if it exists
    if [ -f "$HOME/.bashrc" ]; then
    . "$HOME/.bashrc"
    fi
fi

# set PATH so it includes user's private bin directories
PATH="$HOME/bin:$HOME/.local/bin:$PATH"
  • Continue the rest of the install.sh as usual.
@nwinkler
Copy link
Member

Great suggestion - please feel free to provide a PR for this!

@nwinkler nwinkler added feature request seems abandoned rattle the cage, and close if nobody wants to keep it going help wanted NeedsPR labels Dec 17, 2019
@NoahGorny NoahGorny removed the needs PR label Feb 5, 2021
@gaelicWizard gaelicWizard linked a pull request Jan 13, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request help wanted seems abandoned rattle the cage, and close if nobody wants to keep it going
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants