Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbalanced connector #3

Closed
maltelenz opened this issue Apr 5, 2023 · 2 comments
Closed

Unbalanced connector #3

maltelenz opened this issue Apr 5, 2023 · 2 comments

Comments

@maltelenz
Copy link

ShipSIM.Interfaces.ShipData has 14 potential signals but no flow signals. This is not legal Modelica, see https://specification.modelica.org/maint/3.6/connectors-and-connections.html#balancing-restriction-and-size-of-connectors

For each non-partial non-expandable connector class the number of flow variables shall be equal to the number of variables that are neither parameter, constant, input, output, stream nor flow.

Maybe it can be solved with some input and output prefixes, since it looks like these are intended to be directional?
@BasilioPV
Copy link
Owner

Hi Malte,
Thanks for your feedback. I have produced two connectors with input and output prefixes. I think that is solved now.

@maltelenz
Copy link
Author

Looks like legal Modelica now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maltelenz @BasilioPV