Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build succeeds even if SWIG is not found, breaking examples. #20

Open
pgorczak opened this issue Jul 24, 2017 · 2 comments
Open

Build succeeds even if SWIG is not found, breaking examples. #20

pgorczak opened this issue Jul 24, 2017 · 2 comments
Labels

Comments

@pgorczak
Copy link

pgorczak commented Jul 24, 2017

Building without SWIG seems to work fine but it breaks the examples, resulting e.g. in #11.

Is SWIG always required for gr-lora to work? If it is, we should make the build fail if it can't be found, by changing CMakeLists.txt line 31 to

find_package(SWIG REQUIRED)

If there are cases where you want to just skip the Python bindings, we could instead add a warning before CMakeLists.txt line 34 like

message(WARNING "SWIG or Python-libs not found. Skipping Python bindings.")
message(WARNING "Note that examples won't work!")

Since I'm a total GNUradio noob, I can't tell which one is right, so not opening a PR yet ¯\_(ツ)_/¯

@matt-knight
Copy link
Contributor

Hi @pgorczak,

Thanks for noting this. While technically one can use GNU Radio without the Python layer (thus not requiring SWIG), I don't know a single person who does this. So I am of the opinion that your first solution mandating the use of SWIG is the way to go.

I'm happy to handle this, unless you'd rather do the honors.

Best,
Matt

@matt-knight matt-knight added the bug label Aug 2, 2017
@pgorczak
Copy link
Author

pgorczak commented Aug 2, 2017

Hey I just opened #21 after seeing how easy minor edits are from the website :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants