Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputFileName not used #15

Open
JonathanCrossland opened this issue Feb 10, 2021 · 3 comments
Open

outputFileName not used #15

JonathanCrossland opened this issue Feb 10, 2021 · 3 comments

Comments

@JonathanCrossland
Copy link

Example of outputFileName in json or settings file would be nice. I could not get anything to an outputfile only a tmp file.

@mariomui
Copy link
Contributor

mariomui commented Mar 8, 2023

https://www.loom.com/share/e49936ee46b84172b7a1688bbe357a57

https://stackoverflow.com/questions/57377597/vscode-how-do-i-find-what-my-workspace-folder-is
From the article above, i figured they really don't want you to use workspaceRoot, they want workspacefolder but workspace folder is really far down the tmp stack, all the way in application support, so the closer one is...fileWorkspaceFolder
https://code.visualstudio.com/docs/editor/variables-reference#_predefined-variables-examples

I also went into the ~/.vscode/extensions and messed with the package.json so i could default have the outputFileName output to the directory of the folder i am combining these folders in. It isn't tested on remote workspaces.

I"ll spin up a pull request soonish.

@mariomui
Copy link
Contributor

mariomui commented Mar 8, 2023

@CobusKruger should probably update the docs to reflect the fix. I'm not sure how you handle ticketing but this issue should be closed for now. Maybe someone with a windows PC should test out the markdown fix as well.

@mariomui
Copy link
Contributor

@CobusKruger you should close this ticket as the previous PR i submitted fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants