Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate embed Page.Event to a relational table PageEventHandlers #321

Closed
6 tasks
leandrocp opened this issue Aug 8, 2023 · 0 comments · Fixed by #328
Closed
6 tasks

Migrate embed Page.Event to a relational table PageEventHandlers #321

leandrocp opened this issue Aug 8, 2023 · 0 comments · Fixed by #328
Labels
enhancement New feature or improvement help wanted Looking for contributors

Comments

@leandrocp
Copy link
Contributor

We need to migrate the existing embed Page.Event into its own table beacon_page_event_handlers and schema Beacon.Content.PageEventHandler, similar to how #296 was implemented.

  • Remove
    embeds_many :events, Event do
    field :name, :string
    field :code, :string
    end
  • Create table
  • Create schema
  • Create has_many :event_handlers association in Content.Page
  • Preload :event_handlers association like was done on PR Add page variants #296
  • Fix tests and old mentions to that code
@leandrocp leandrocp added enhancement New feature or improvement help wanted Looking for contributors labels Aug 8, 2023
@AZholtkevych AZholtkevych moved this to Done in Beacon Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement help wanted Looking for contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant