Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components and Pages: Create new layouts with a default template #345

Closed
leandrocp opened this issue Sep 7, 2023 · 2 comments
Closed

Components and Pages: Create new layouts with a default template #345

leandrocp opened this issue Sep 7, 2023 · 2 comments
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors

Comments

@leandrocp
Copy link
Contributor

leandrocp commented Sep 7, 2023

When a new layout is created, its template should have the following default content:

<%= @inner_content %>

That's necessary to render the page content using that layout, so it starts with that default content to help users creating new layouts. But it won't be enforced for now, users could remove that line.

@leandrocp leandrocp added this to the Version 0.1.0 milestone Sep 20, 2023
@AZholtkevych AZholtkevych moved this to Todo in Beacon Sep 20, 2023
@AZholtkevych AZholtkevych changed the title Create new layouts with a default template Core -> Components and Pages: Create new layouts with a default template Sep 25, 2023
@AZholtkevych AZholtkevych mentioned this issue Sep 25, 2023
29 tasks
@leandrocp leandrocp removed the status in Beacon Oct 20, 2023
@leandrocp leandrocp moved this to Todo in Beacon Oct 20, 2023
@AZholtkevych AZholtkevych changed the title Core -> Components and Pages: Create new layouts with a default template Components and Pages: Create new layouts with a default template Oct 23, 2023
@AZholtkevych AZholtkevych moved this from Todo to Backlog in Beacon Oct 23, 2023
@leandrocp leandrocp moved this from Backlog to Todo in Beacon Oct 31, 2023
@leandrocp leandrocp added enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors labels Oct 31, 2023
@leandrocp leandrocp removed this from the v0.1.0 milestone Nov 1, 2023
@edborsa
Copy link
Contributor

edborsa commented Dec 9, 2023

Hey @leandrocp, I want to start contributing, haha.
And this one seems easy.

Here is the PR:
#383

(BTW, great talk on Elixir em Foco. I bought the "How to Open Source" book)

If there are any guidelines and tips you want to suggest, or changes, please let me know.

Best regards

@leandrocp
Copy link
Contributor Author

Closed by #383

@AZholtkevych AZholtkevych moved this from Todo to Done in Beacon Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement good first issue Good for newcomers help wanted Looking for contributors
Projects
Status: Done
Development

No branches or pull requests

2 participants