Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dihedral Analysis #190

Closed
2 tasks done
ALescoulie opened this issue Sep 9, 2021 · 4 comments · Fixed by #193
Closed
2 tasks done

Adding Dihedral Analysis #190

ALescoulie opened this issue Sep 9, 2021 · 4 comments · Fixed by #193
Assignees
Labels
Milestone

Comments

@ALescoulie
Copy link
Contributor

ALescoulie commented Sep 9, 2021

MDPOW.analysis.dihedral

The dihedral analysis script will be build using EnsembleAnalysis to get the dihedrals for given atom groups. My plan is for it to take an EnsembleAtomGroup with four atoms selected from each system, then return the dihedrals in a DataFrame

  • Implement DihdralAnalysis class with EnsembleAnalysis
  • Develop tests
@ALescoulie ALescoulie self-assigned this Sep 9, 2021
@orbeckst orbeckst added this to the 0.8.0 milestone Sep 10, 2021
@orbeckst
Copy link
Member

@ALescoulie are you going to do the PR for changing Ensemble before pushing this one?

@ALescoulie
Copy link
Contributor Author

Yeah, I'll get that one up soon

@ALescoulie
Copy link
Contributor Author

@orbeckst the fix to EnsembleAtomGroup.ensemble() is up on PR #192, with that I'll be less concerned about passing a list of EnsembleAtomGroups into DihedralAnalysis. Do you want the analysis modules to be added via individual PRs.

@orbeckst
Copy link
Member

Yes, make each analysis module a separate PR with a separate issue as this keeps discussion focused. It also helps if one thing turns out to be more complicated than others, then that won't hold up the others.

@orbeckst orbeckst linked a pull request Sep 10, 2021 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants