Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try remove defaults and unpin HDF5 package #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hmacdope
Copy link
Collaborator

@hmacdope hmacdope commented Feb 16, 2025

Try fix #79 with removing defaults.

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.78%. Comparing base (836874d) to head (215e9c1).

Additional details and impacted files

@hmacdope
Copy link
Collaborator Author

@ljwoods2 looks to me like there are some zarr compatibility issues to fix here.

@@ -1,6 +1,5 @@
name: zarrtraj-test
channels:
- defaults
Copy link
Member

@orbeckst orbeckst Feb 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good and should be our default. (I mean: "Removing - defaults should be our default.)

(Although it's probably what many people do in practice!)

@ljwoods2
Copy link
Collaborator

ljwoods2 commented Feb 24, 2025

@ljwoods2 looks to me like there are some zarr compatibility issues to fix here.

Looks like LRUStoreCache was quietly removed and I can't find any migration notes or release notes for it.

There are notes for other removed stores here:

https://zarr.readthedocs.io/en/latest/user-guide/v3_migration.html#

Edit: raised an issue zarr-developers/zarr-python#2857, hopefully there is another way to do this, this had saved me a ton of time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix exact HDF5 pin once fixed upstream
3 participants