You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that under Developer Tools > Events, the luxtronik2_data_update event has 25 listeners. This is noticable because:
It is the only integration I have seen with it's own listeners
it is the 3rd most subscribed to event (only surpassed by HA stop and registry updates).
While many integrations need to listen for updates, none of them seem to use their own event handler and none of them have so many listeners. The developer documentation state attributed events should be used instead. I expect that using events like most other integrations will improve UI responsiveness template sensors updates and overall stability and performance.
The Luxtronik integration heavily impacts the performance, responsiveness and stability of the entire Home Assistant platform. Disabling the integration has a noticable positive impact. My theory is that the non-standard use of events contributes to this.
I doubt the use of custom event listeners is acceptable for a native HA integration (assuming this is still a goal for this integration).
Proposal:
How do custom event listeners differ from other integrations (code comparison).
How can we test/validate the impact of custom event listeners?
Discuss the possible impact of custom event listener to standard event listener.
Choose a way forward.
Update integration (if needed).
The text was updated successfully, but these errors were encountered:
This is old code and I can remove it next time.
But it is never fired so it can not have an big impact.
And in future release I would like to use events and I have to re add it.
I noticed that under
Developer Tools
>Events
, theluxtronik2_data_update
event has 25 listeners. This is noticable because:While many integrations need to listen for updates, none of them seem to use their own event handler and none of them have so many listeners. The developer documentation state attributed events should be used instead. I expect that using events like most other integrations will improve UI responsiveness template sensors updates and overall stability and performance.
The Luxtronik integration heavily impacts the performance, responsiveness and stability of the entire Home Assistant platform. Disabling the integration has a noticable positive impact. My theory is that the non-standard use of events contributes to this.
I doubt the use of custom event listeners is acceptable for a native HA integration (assuming this is still a goal for this integration).
Proposal:
The text was updated successfully, but these errors were encountered: