Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datapack question (maybe bug?) #66

Open
MrZero1 opened this issue Mar 11, 2024 · 9 comments
Open

Datapack question (maybe bug?) #66

MrZero1 opened this issue Mar 11, 2024 · 9 comments

Comments

@MrZero1
Copy link

MrZero1 commented Mar 11, 2024

Expected behavior

Actually, it's not a bug (i think), but a question I didn't get an answer to on Discord.
If I use the suggested datapack, should I keep the bukkit datapack/file?

Observed/Actual behavior

image3
image1
image

Steps/models to reproduce

I need help :c

BentoBox version

[18:21:32 INFO]: Jelenlegi verzió: PAPER 1.20.4.
[18:21:32 INFO]: (git-Paper-436 (MC: 1.20.4))
[18:21:32 INFO]: BentoBox verzió: 2.1.1
[18:21:32 INFO]: Adatbázis: JSON
[18:21:32 INFO]: Betöltött játék világok:
[18:21:32 INFO]: boxed_world (Boxed): Alap világ, Pokol
[18:21:32 INFO]: Betöltött bővítmények:
[18:21:32 INFO]: Biomes 2.1.1 (ENABLED)
[18:21:32 INFO]: Border 4.2.1 (ENABLED)
[18:21:32 INFO]: Boxed 2.4.0 (ENABLED)
[18:21:32 INFO]: CauldronWitchery 2.0.1 (ENABLED)
[18:21:32 INFO]: Challenges 1.2.0 (ENABLED)
[18:21:32 INFO]: Chat 1.1.4 (ENABLED)
[18:21:32 INFO]: CheckMeOut 1.1.1 (ENABLED)
[18:21:32 INFO]: ControlPanel 1.13.1 (ENABLED)
[18:21:32 INFO]: DimensionalTrees 1.7.0 (ENABLED)
[18:21:32 INFO]: Greenhouses 1.7.5 (ENABLED)
[18:21:32 INFO]: InvSwitcher 1.12.0 (ENABLED)
[18:21:32 INFO]: Level 2.12.0 (ENABLED)
[18:21:32 INFO]: Likes 2.3.1 (ENABLED)
[18:21:32 INFO]: MagicCobblestoneGenerator 2.5.1 (ENABLED)
[18:21:32 INFO]: TwerkingForTrees 1.5.0 (ENABLED)
[18:21:32 INFO]: Visit 1.6.0 (ENABLED)
[18:21:32 INFO]: Warps 1.14.0 (ENABLED)

Plugin list

[18:21:21 INFO]: ------------=[ ServerUtils Plugins ]=-------------
[18:21:21 INFO]: Plugins (36): ArmorStandEditor, BKCommonLib, BentoBox, BentoBox-Biomes, BentoBox-Boxed, BentoBox-CauldronWitchery, BentoBox-Challenges, BentoBox-CheckMeOut, BentoBox-Greenhouses, BentoBox-Level, BentoBox-Likes, BentoBox-MagicCobblestoneGenerator, BentoBox-Visit, BentoBox-Warps, Essentials, EssentialsChat, EssentialsSpawn, EvenMoreFish, ExcellentCrates, ExcellentEnchants, FastAsyncWorldEdit, InfernalMobs, LuckPerms, My_Worlds, NexEngine, ODailyQuests, Oraxen, PlaceholderAPI, ProtocolLib, ServerUtils, TAB, Vault, ViaBackwards, ViaVersion, WorldGuard and ntdLuckyBlock

Other

@tastybento
Copy link
Member

Yes, at least you don't need to remove anything AFAIK. I haven't and it all seems to work fine.

@MrZero1
Copy link
Author

MrZero1 commented Mar 17, 2024

I apologize, I hope you are reading a closed notification question, but I don't know if I should open a new bug ticket.

So, I have installed the suggested datapack (Custom Advancements), however when I restart the server, the console displays the following error messages. How can I fix this?

Also, my question is, with this datapack package, if all the advancements are done, will it reach the maximum island level?

[17:59:43 INFO]: Loaded 1220 recipes
[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:caving/glow_berries: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:cave_vines"],"state":{"berries":true}}}} missed input: {"grow_berries":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:bone_meal"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:cave_vines"],"state":{"berries":true}}}}]}}}
[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:redstone/pressure_plate: Not a JSON object: true missed input: {"powered":true} missed input: {"tripwire":{"trigger":"minecraft:location","conditions":{"player":{"location":{"block":{"tag":"pressure_plates","state":{"powered":true}}}}}}}
[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:caving/5: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}} missed input: {"5":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:music_disc_5"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}}]}}}
[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:exploration/grow_propagule: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:mangrove_propagule"],"state":{"hanging":true}}}} missed input: {"propagule":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:bone_meal"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:mangrove_propagule"],"state":{"hanging":true}}}}]}}}
[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:exploration/jukebox_meadow: Not a json array: {"condition":"minecraft:location_check","predicate":{"biome":"minecraft:meadow","block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}} missed input: {"play_jukebox_in_meadows":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:location_check","predicate":{"biome":"minecraft:meadow","block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}}]}}}
[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:redstone/tripwire: Not a JSON object: false; Not a JSON object: true missed input: {"attached":true,"disarmed":false} missed input: {"tripwire":{"trigger":"minecraft:enter_block","conditions":{"block":"minecraft:tripwire","state":{"attached":true,"disarmed":false}}}}
[17:59:43 ERROR]: Couldn't load advancements: [bentobox:redstone/detector_rail, bentobox:redstone/tnt_minecart, bentobox:redstone/trapped_chest, bentobox:redstone/tnt, bentobox:redstone/payback]
[17:59:43 INFO]: Loaded 1682 advancements

@MrZero1
Copy link
Author

MrZero1 commented Mar 17, 2024

kép

Another question. If I have made a progress, does it show otherwise? Or how do I know if I have already made a step forward?

@tastybento
Copy link
Member

I apologize, I hope you are reading a closed notification question, but I don't know if I should open a new bug ticket.

So, I have installed the suggested datapack (Custom Advancements), however when I restart the server, the console displays the following error messages. How can I fix this?

Also, my question is, with this datapack package, if all the advancements are done, will it reach the maximum island level?

[17:59:43 INFO]: Loaded 1220 recipes

[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:caving/glow_berries: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:cave_vines"],"state":{"berries":true}}}} missed input: {"grow_berries":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:bone_meal"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:cave_vines"],"state":{"berries":true}}}}]}}}

[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:redstone/pressure_plate: Not a JSON object: true missed input: {"powered":true} missed input: {"tripwire":{"trigger":"minecraft:location","conditions":{"player":{"location":{"block":{"tag":"pressure_plates","state":{"powered":true}}}}}}}

[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:caving/5: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}} missed input: {"5":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:music_disc_5"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}}]}}}

[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:exploration/grow_propagule: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:mangrove_propagule"],"state":{"hanging":true}}}} missed input: {"propagule":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:bone_meal"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:mangrove_propagule"],"state":{"hanging":true}}}}]}}}

[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:exploration/jukebox_meadow: Not a json array: {"condition":"minecraft:location_check","predicate":{"biome":"minecraft:meadow","block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}} missed input: {"play_jukebox_in_meadows":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:location_check","predicate":{"biome":"minecraft:meadow","block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}}]}}}

[17:59:43 ERROR]: Parsing error loading custom advancement bentobox:redstone/tripwire: Not a JSON object: false; Not a JSON object: true missed input: {"attached":true,"disarmed":false} missed input: {"tripwire":{"trigger":"minecraft:enter_block","conditions":{"block":"minecraft:tripwire","state":{"attached":true,"disarmed":false}}}}

[17:59:43 ERROR]: Couldn't load advancements: [bentobox:redstone/detector_rail, bentobox:redstone/tnt_minecart, bentobox:redstone/trapped_chest, bentobox:redstone/tnt, bentobox:redstone/payback]

[17:59:43 INFO]: Loaded 1682 advancements

These do look like errors. I'll try and find out what is going wrong.

@tastybento tastybento reopened this Mar 17, 2024
@tastybento
Copy link
Member

If you do an Advancement then it is shown in the Advancement GUI.

I have not aligned the advancements to ensure that the Box size will be maximized if they are all done. Indeed, I don't know for sure that it is possible to do all of them, sorry. For example, I don't think every Biome is available. So, I'm open to suggestions to improve things.

@MrZero1
Copy link
Author

MrZero1 commented Mar 19, 2024

I think it would be cool if the proposed advanced datapack could be adapted to your box's default settings, and all progress could be done within the generated world.

So I don't see how you could use the advanced datapack, especially if you run some on error and don't load all of them, or if they do load, you can't perform them.

@MrZero1
Copy link
Author

MrZero1 commented Mar 24, 2024

Well, the console reported an error with these advances, so I deleted them. Hope this is not a big problem..

[10:48:36 ERROR]: Parsing error loading custom advancement bentobox:caving/glow_berries: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:cave_vines"],"state":{"berries":true}}}} missed input: {"grow_berries":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:bone_meal"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:cave_vines"],"state":{"berries":true}}}}]}}}
[10:48:36 ERROR]: Parsing error loading custom advancement bentobox:redstone/pressure_plate: Not a JSON object: true missed input: {"powered":true} missed input: {"tripwire":{"trigger":"minecraft:location","conditions":{"player":{"location":{"block":{"tag":"pressure_plates","state":{"powered":true}}}}}}}
[10:48:36 ERROR]: Parsing error loading custom advancement bentobox:caving/5: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}} missed input: {"5":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:music_disc_5"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}}]}}}
[10:48:36 ERROR]: Parsing error loading custom advancement bentobox:exploration/grow_propagule: Not a json array: {"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:mangrove_propagule"],"state":{"hanging":true}}}} missed input: {"propagule":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:match_tool","predicate":{"items":["minecraft:bone_meal"]}},{"condition":"minecraft:location_check","predicate":{"block":{"blocks":["minecraft:mangrove_propagule"],"state":{"hanging":true}}}}]}}}
[10:48:36 ERROR]: Parsing error loading custom advancement bentobox:exploration/jukebox_meadow: Not a json array: {"condition":"minecraft:location_check","predicate":{"biome":"minecraft:meadow","block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}} missed input: {"play_jukebox_in_meadows":{"trigger":"minecraft:item_used_on_block","conditions":{"location":[{"condition":"minecraft:location_check","predicate":{"biome":"minecraft:meadow","block":{"blocks":["minecraft:jukebox"],"state":{"has_record":true}}}}]}}}
[10:48:36 ERROR]: Parsing error loading custom advancement bentobox:redstone/tripwire: Not a JSON object: false; Not a JSON object: true missed input: {"attached":true,"disarmed":false} missed input: {"tripwire":{"trigger":"minecraft:enter_block","conditions":{"block":"minecraft:tripwire","state":{"attached":true,"disarmed":false}}}}
[10:48:36 ERROR]: Couldn't load advancements: [bentobox:redstone/detector_rail, bentobox:redstone/tnt_minecart, bentobox:redstone/trapped_chest, bentobox:redstone/tnt, bentobox:redstone/payback]
[10:57:57 ERROR]: Couldn't load advancements: [bentobox:redstone/tnt_minecart, bentobox:redstone/trapped_chest, bentobox:redstone/tnt, bentobox:redstone/payback]
[10:59:41 ERROR]: Couldn't load advancements: [bentobox:redstone/trapped_chest, bentobox:redstone/tnt, bentobox:redstone/payback]
[11:01:03 ERROR]: Couldn't load advancements: [bentobox:redstone/tnt, bentobox:redstone/payback]
[11:02:16 ERROR]: Couldn't load advancements: [bentobox:redstone/payback]

@MrZero1
Copy link
Author

MrZero1 commented Mar 24, 2024

If I make an advancement, shouldn't I see it differently in the GUI?
For vanilla advances, the colour of the completed advance changes.

kép

@tastybento
Copy link
Member

Deleting advancements that don't work should be fine. In terms of advancements they will act the same whether they are custom or vanilla. I recommend you look for videos or tutorials on custom advancement datapacks. I used this site to edit them: https://misode.github.io/advancement/

They often need updating with new versions of Minecraft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants