Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hard coded layer names #1

Open
ThomasHalwax opened this issue Mar 7, 2020 · 2 comments
Open

hard coded layer names #1

ThomasHalwax opened this issue Mar 7, 2020 · 2 comments

Comments

@ThomasHalwax
Copy link

This project is truly limited to the basemap.at vector tiles since you embed all(?) layer names into OutputMbtiles.cs.

To make vtpk2mbtiles beneficial for others you need to read the layer names from the tiles.

@wilhelmberg
Copy link
Collaborator

wilhelmberg commented Mar 7, 2020

Thanks for pointing out.
But the mentioned method with the hard coded layer names is just a left over that should have been removed already, it never gets called.

Nevertheless, I'm using a shortcut by extracting the layer names from the style - for speed.
Didn't want to check all +160.000 tiles for which layers they actually contain.
When checking layers already, one could also check the fields they contain and provide a real proper tile.json.
But then again, since the vt spec allows every feature to have different properties I didn't want to go into checking that for consistency as well.

@wilhelmberg
Copy link
Collaborator

I think we both know that the layer and attribute names in the vtpk tiles are an absolute mess, changing between zoom levels for the same content (what should be the same layer).
Also, if all vtpk metadata would be properly read and output as provided, it wouldn't match the actual vtpk tiles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants