Skip to content

Commit aac63c6

Browse files
committed
proposed fix of issue coverlet-coverage#1679
1 parent 99010b0 commit aac63c6

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

Diff for: src/coverlet.core/Coverage.cs

+11-11
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ public CoveragePrepareResult PrepareModules()
108108
_parameters.IncludeFilters = _parameters.IncludeFilters?.Where(f => _instrumentationHelper.IsValidFilterExpression(f)).ToArray();
109109

110110
IReadOnlyList<string> validModules = _instrumentationHelper.SelectModules(modules, _parameters.IncludeFilters, _parameters.ExcludeFilters).ToList();
111-
foreach (var excludedModule in modules.Except(validModules))
111+
foreach (string excludedModule in modules.Except(validModules))
112112
{
113113
_logger.LogVerbose($"Excluded module: '{excludedModule}'");
114114
}
@@ -365,16 +365,6 @@ private void CalculateCoverage()
365365
{
366366
foreach (InstrumenterResult result in _results)
367367
{
368-
if (!_fileSystem.Exists(result.HitsFilePath))
369-
{
370-
// Hits file could be missed mainly for two reason
371-
// 1) Issue during module Unload()
372-
// 2) Instrumented module is never loaded or used so we don't have any hit to register and
373-
// module tracker is never used
374-
_logger.LogVerbose($"Hits file:'{result.HitsFilePath}' not found for module: '{result.Module}'");
375-
continue;
376-
}
377-
378368
var documents = result.Documents.Values.ToList();
379369
if (_parameters.UseSourceLink && result.SourceLink != null)
380370
{
@@ -386,6 +376,16 @@ private void CalculateCoverage()
386376
}
387377
}
388378

379+
if (!_fileSystem.Exists(result.HitsFilePath))
380+
{
381+
// Hits file could be missed mainly for two reason
382+
// 1) Issue during module Unload()
383+
// 2) Instrumented module is never loaded or used so we don't have any hit to register and
384+
// module tracker is never used
385+
_logger.LogVerbose($"Hits file:'{result.HitsFilePath}' not found for module: '{result.Module}'");
386+
continue;
387+
}
388+
389389
// Calculate lines to skip for every hits start/end candidate
390390
// Nested ranges win on outermost one
391391
foreach (HitCandidate hitCandidate in result.HitCandidates)

0 commit comments

Comments
 (0)