-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish pipeline doesn't build before publishing #65
Comments
I will investigate the issue this evening. Here's the GitHub Action which handles the release. I guess the build job shouldn't be separate from the release job and instead we should build the files right before running the release action. |
That seems about right. release:
needs: [lint]
name: Build and release
runs-on: ubuntu-latest
if: "!contains(github.event.head_commit.message, '[skip ci]')"
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 14
- name: Cache node modules
uses: c-hive/gha-npm-cache@v1
- name: Install dependencies
run: npm ci
- name: Run build command:
run: npm run build
- name: Run Semantic Release
run: npx semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GH_PAT }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
GIT_AUTHOR_NAME: "BetaHuhn Bot"
GIT_AUTHOR_EMAIL: "bot@mxis.ch"
GIT_COMMITTER_NAME: "BetaHuhn Bot"
GIT_COMMITTER_EMAIL: "bot@mxis.ch" |
Yes exactly. I will fix this in the evening when I am off work or if you want you can create a PR. |
Your publishing pipeline seems to be automated, but it doesn't look like it's actually building your package before publishing it.
Originally posted by @utrolig in #64
The text was updated successfully, but these errors were encountered: