Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish pipeline doesn't build before publishing #65

Closed
BetaHuhn opened this issue Mar 11, 2021 · 4 comments
Closed

Publish pipeline doesn't build before publishing #65

BetaHuhn opened this issue Mar 11, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@BetaHuhn
Copy link
Owner

Your publishing pipeline seems to be automated, but it doesn't look like it's actually building your package before publishing it.

Originally posted by @utrolig in #64

@BetaHuhn
Copy link
Owner Author

BetaHuhn commented Mar 11, 2021

I will investigate the issue this evening. Here's the GitHub Action which handles the release. I guess the build job shouldn't be separate from the release job and instead we should build the files right before running the release action.

@BetaHuhn BetaHuhn added the bug Something isn't working label Mar 11, 2021
@utrolig
Copy link
Contributor

utrolig commented Mar 11, 2021

That seems about right.
I think you could probably scrap the whole build section, and just add npm run build to the release step

release:
    needs: [lint]
    name: Build and release
    runs-on: ubuntu-latest
    if: "!contains(github.event.head_commit.message, '[skip ci]')"
    steps:
      - name: Checkout
        uses: actions/checkout@v2
      - name: Setup Node.js
        uses: actions/setup-node@v2
        with:
          node-version: 14
      - name: Cache node modules
        uses: c-hive/gha-npm-cache@v1
      - name: Install dependencies
        run: npm ci
      - name: Run build command:
        run: npm run build
      - name: Run Semantic Release
        run: npx semantic-release
        env:
          GITHUB_TOKEN: ${{ secrets.GH_PAT }}
          NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
          GIT_AUTHOR_NAME: "BetaHuhn Bot"
          GIT_AUTHOR_EMAIL: "bot@mxis.ch"
          GIT_COMMITTER_NAME: "BetaHuhn Bot"
          GIT_COMMITTER_EMAIL: "bot@mxis.ch"

@BetaHuhn
Copy link
Owner Author

Yes exactly.

I will fix this in the evening when I am off work or if you want you can create a PR.

@BetaHuhn
Copy link
Owner Author

Fixed in #66, thanks @utrolig!

I will release a new version later which should hopefully include the built files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants