Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

topAnatData S4 class validity #18

Open
julien-roux opened this issue Jun 20, 2017 · 0 comments
Open

topAnatData S4 class validity #18

julien-roux opened this issue Jun 20, 2017 · 0 comments

Comments

@julien-roux
Copy link
Contributor

It is a good practice to validate the objects using a validity method (setValidity for S4 classes).

In topAnat.R we extend from topGOdata class but do not perform such a validity check. As far as I can tell, topGO doesn;t do it either... (see the AllClasses.R files in their package).

A good point (more elegant) is that it could replace/gather some checks that are now made in the beginning of the topAnat function...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant