-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
header images for webapp #4
Comments
Sure @olunusib 👍 |
@olunusib Are you working on this ? |
Hi, is this issue still open? |
yes it is |
I can give it a shot! |
Please assign it when you can. |
Hi, I implemented a way for this to work using the media_content and links keys as suggested. This works well for the general and news feeds, but those keys almost never exist for the podcasts or newsletters feeds. Should I submit a pull request for this initial solution? |
Sure. We can ignore header images for podcasts and newsletters |
Hello @Bhupesh-V , I would like to work on this issue. This is my first contribution . Please assign me a file accordingly. |
Is your feature request related to a problem? Please describe.
It would be nice to show some header images (if the feed provides it)
Something like this probably
Describe the solution you'd like
For every card rendered on webapp we can show the image if it exists
The
feedparser
library colllects these links for us in a single keyUsually the images will exist in either the
links
key or sometimes inmedia_content
One thing to note that the images may exist for some source & not for others, so make sure there is a fallback mechanism (if/else to say 😅 )
The text was updated successfully, but these errors were encountered: