Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests #102

Closed
liamdalg opened this issue Feb 7, 2020 · 11 comments
Closed

Unit Tests #102

liamdalg opened this issue Feb 7, 2020 · 11 comments
Assignees
Labels
documentation Improvements or additions to documentation network Issues and PRs related to the network development packets test
Milestone

Comments

@liamdalg
Copy link
Contributor

liamdalg commented Feb 7, 2020

What Do You Want?
Should probably start testing our really ugly code, especially the server/client packets.

How Do We Do It?
Implement a TestServer and TestClient (or equivalent) which just send a bunch of packets to each other.

@liamdalg liamdalg added enhancement New feature or request documentation Improvements or additions to documentation network Issues and PRs related to the network development packets and removed enhancement New feature or request labels Feb 7, 2020
@ghost ghost removed their assignment Feb 7, 2020
@RileyEv RileyEv assigned ghost Feb 9, 2020
@RileyEv
Copy link
Member

RileyEv commented Feb 9, 2020

We should probably have unit tests too on the packet serialising/deserialising

@ghost ghost removed their assignment Feb 9, 2020
@RileyEv RileyEv assigned ghost Feb 28, 2020
@RileyEv
Copy link
Member

RileyEv commented Feb 28, 2020

We might want to do this

@RileyEv
Copy link
Member

RileyEv commented Mar 1, 2020

I'll start to have a look at this shit

@RileyEv RileyEv added this to the End of Explore Week milestone Mar 2, 2020
@RileyEv RileyEv added the test label Mar 2, 2020
@ChrisGora
Copy link
Contributor

I had a quick look (see branch UTF-is-shit). In summary, we might be able to write some tests, but I had a ton of errors that it didn't see any of the Networking classes when running any tests and I stopped there.

@RileyEv
Copy link
Member

RileyEv commented Mar 5, 2020

might be a stupid question but why UTF?

I had a quick look (see branch UTF-is-shit). In summary, we might be able to write some tests, but I had a ton of errors that it didn't see any of the Networking classes when running any tests and I stopped there.

@RileyEv
Copy link
Member

RileyEv commented Mar 5, 2020

My plan was to have a look tomorrow at some test stuff

@ChrisGora
Copy link
Contributor

Unity Testing Framework

@RileyEv
Copy link
Member

RileyEv commented Mar 5, 2020

I managed to get the tests working, you have to run them in unity though, rider doesn't seem to work for me

@ChrisGora
Copy link
Contributor

I'll try to write a real test for the RoundManager. On another note, should we be commiting stuff in the packages folder? I was adding to the .gitignore cos I don't think that stuff needs to be on the repo.

@RileyEv
Copy link
Member

RileyEv commented Mar 5, 2020

they don't seem to be included in this https://github.com/github/gitignore/blob/master/Unity.gitignore

so I'm inclined to keep them

@ChrisGora ChrisGora changed the title Packet Tests Unit Tests Mar 7, 2020
@ChrisGora
Copy link
Contributor

Split into #251 and #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation network Issues and PRs related to the network development packets test
Projects
None yet
Development

No branches or pull requests

3 participants