Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should we rename this repo to "scikit-package-conda-forge"? #31

Closed
bobleesj opened this issue Jan 5, 2025 · 7 comments
Closed

Comments

@bobleesj
Copy link
Contributor

bobleesj commented Jan 5, 2025

The goal is to remain consistent..

User can generate meta.yaml by running 'package conda-forge' once the user has done pip installed scikit-package?

@bobleesj
Copy link
Contributor Author

bobleesj commented Jan 5, 2025

If this is a good idea, I can implement "package conda-forge" in scikit-package to run "cookiecutt" this repo URL.

@bobleesj bobleesj changed the title fix: should we rename this repo to "scikit-package-conda-forge" fix: should we rename this repo to "scikit-package-conda-forge"? Jan 5, 2025
@sbillinge
Copy link
Collaborator

It probably depends if we are just going to keep this as our local place where we keep our group conda-forge meta-yamls under git control or if we want this to be part of scikit-package

@bobleesj
Copy link
Contributor Author

bobleesj commented Jan 5, 2025

Maybe as a separate repo because cookiecutter uses the github repo URL to initiate it:

When package create is entered, the following is executed in app.py:

cookiecutter https://github.com/Billingegroup/scikit-package

I believe that when we run package conda-forge, we could run:

cookiecutter https://github.com/Billingegroup/scikit-package-conda-forge

To me it's the simplest solution since we just need to modify the repo name and also we could create other commands linking other community's repos in the future.. (we could view https://github.com/Billingegroup/scikit-package-conda-forge like a plugin/independent project)

@sbillinge
Copy link
Collaborator

OK, that sounds reasonable.

@bobleesj
Copy link
Contributor Author

bobleesj commented Jan 6, 2025

Could you pls update the repo URL?

@sbillinge
Copy link
Collaborator

sorry, done it. Renamed to scikit-package-conda-forge

@bobleesj
Copy link
Contributor Author

bobleesj commented Jan 6, 2025

Closing - repo name changed

@bobleesj bobleesj closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants