Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session not closed in class-billmate-cardpay.php #466

Open
matteth opened this issue Sep 14, 2020 · 6 comments
Open

Session not closed in class-billmate-cardpay.php #466

matteth opened this issue Sep 14, 2020 · 6 comments

Comments

@matteth
Copy link

matteth commented Sep 14, 2020

WordPress Health check reports: A PHP session was created by a session_start() function call. This interferes with REST API and loopback requests. The session should be closed by session_write_close() before making any HTTP requests.

The error seems to be that the "session_start()" in class-billmate-cardpay.php isn't closed. When session_write_close() is added to the end of the file the error disappears.

@ben72
Copy link
Contributor

ben72 commented Sep 14, 2020

@matteth Good luck! I've been trying to get this fixed a long time. :)
See possible fix in #286. But Billmate says there is an issue with Billmate Checkout using that fix.
Last time I heard, they said they will split custom pay and the checkout into two plugins and then it can be fixed in the custom pay plugin. But it seems you're using the checkout?

@matteth
Copy link
Author

matteth commented Sep 15, 2020

@ben72 Ok 😬 Yes, we're using the checkout,

@ben72
Copy link
Contributor

ben72 commented Sep 15, 2020

@Mattet Well this one is important to fix! For us it messes up Mailchimp sync. :(
So I always have to patch it after updating..

@MattiasNilsson
Copy link
Contributor

We are currently developing a new Billmate Checkout plugin for Woocommerce. This will not have that issue. Will keep you posted!

@MattiasNilsson
Copy link
Contributor

This is now fixed with release: https://github.com/Billmate/woocommerce/releases/tag/3.11.3

@ben72
Copy link
Contributor

ben72 commented Sep 24, 2020

Re-open as the fix was reverted?

@stefanliden stefanliden reopened this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants