Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delay_timer rebuilds every time. #24

Closed
chaaz opened this issue Oct 5, 2021 · 2 comments · Fixed by #23
Closed

delay_timer rebuilds every time. #24

chaaz opened this issue Oct 5, 2021 · 2 comments · Fixed by #23

Comments

@chaaz
Copy link
Contributor

chaaz commented Oct 5, 2021

Describe the bug
When cargo build is run on a project that depends on delay-timer, it will always rebuild, even if no changes have been made.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new project with cargo new --bin test_proj
  2. Add delay_timer = "0.9.0" to the dependencies section of Cargo.toml
  3. Run cargo build multiple times in succession

Every time cargo build is run, both delay_timer and the test_proj itself are recompiled.

Expected behavior
cargo build should not recompile anything if there have been no changes since the last compile.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: ubuntu 20
  • delay_timer version: 0.9.0
@chaaz
Copy link
Contributor Author

chaaz commented Oct 5, 2021

I've include a PR #23 which I think fixes the problem.

@BinChengZhao
Copy link
Owner

Hi, friends @chaaz

Thanks a lot for your feedback!

This may be caused by the fact that Cargo works differently on different operating systems, I did not see any abnormalities with the Mac-OS test.

But after testing, modifying build.rs also doesn't cause any problems with the existing compilation.

I decided to adopt PR, thanks for your feedback, this can affect Ubutun users a lot!

If there are any more questions or any suggestions on the project, feel free to contact me, thanks for your support suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants